fix: only escaping invalid data, keep valid escaping untouched#484
Open
SolaWing wants to merge 1 commit intohttpswift:stablefrom
Open
fix: only escaping invalid data, keep valid escaping untouched#484SolaWing wants to merge 1 commit intohttpswift:stablefrom
SolaWing wants to merge 1 commit intohttpswift:stablefrom
Conversation
Member
|
@SolaWing Thanks for taking the time to create this PR ! Can you please rebase from the latest changes and add a unit test for your fix ? |
SolaWing
force-pushed
the
pr
branch
2 times, most recently
from
cb2298b to
9c10ca4
Compare
Author
|
@Vkt0r Done |
Contributor
|
@SolaWing Please update the CHANGELOG.md file with a description of your changes. |
Author
|
@michaelenger done |
michaelenger
suggested changes
Oct 7, 2021
Author
|
@michaelenger done |
michaelenger
approved these changes
Oct 8, 2021
Contributor
michaelenger
left a comment
michaelenger
left a comment
There was a problem hiding this comment.
This looks good to me, but I'd like @Vkt0r to double check it 😇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit avoid escaping twice for query already escaping